24 Jan
2024
24 Jan
'24
12:13 p.m.
Matteo Bruni (@Mystral) commented about dlls/d3d9/device.c:
return S_OK; }
+ if (IsEqualGUID(riid, &IID_IDirect3DDevice9On12)) + { + struct d3d9_device *device = impl_from_IDirect3DDevice9Ex(iface); + + if (!device->d3d_parent->d3d9on12) + { + WARN("IDirect3D9 instance wasn't created with D3D9On12 enabled, returning E_NOINTERFACE %p.\n", device->d3d_parent->d3d9on12); + *out = NULL; + return E_NOINTERFACE; + } +
Here we should check that the pD3D12Device value matches with the one used by this d3d9 device. It might be okay if we don't for now but at least a FIXME is necessary. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4915#note_58810