Re: [PATCH 0/1] MR3575: winepulse: Fix crash when requesting exclusive mode with an unsupported format.

[Huw Davies (＠huw)]

Huw Davies (@huw) commented about dlls/winepulse.drv/pulse.c:
> break;
>      }
>
> -    /* This driver does not support exclusive mode. */
> -    if (exclusive && params->result == S_OK)
> -        params->result = params->flow == eCapture ? AUDCLNT_E_UNSUPPORTED_FORMAT : AUDCLNT_E_EXCLUSIVE_MODE_NOT_ALLOWED;
> +    if (exclusive) {
> +        switch (params->result) {
> +        case S_OK:
> +            /* This driver does not support exclusive mode. */
> +            if (params->flow == eRender) {
> +                params->result = AUDCLNT_E_EXCLUSIVE_MODE_NOT_ALLOWED;
> +                break;
> +            }
> +        case S_FALSE:

This fall-through is not very pleasant; please do this in a different way.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/3575#note_42405