Re: [PATCH v3 0/7] MR66: vkd3d-shader/hlsl: Broaden resources support v2 (PART 1).

[Giovanni Mascellani (＠giomasce)]

Giovanni Mascellani (@giomasce) commented about libs/vkd3d-shader/hlsl.y:
> +    struct hlsl_ir_load *sampler_load;
> +    struct hlsl_ir_node *coords;
> +
> +    if (params->args_count != 2 && params->args_count != 4)
> +    {
> +        hlsl_error(ctx, loc, VKD3D_SHADER_ERROR_HLSL_WRONG_PARAMETER_COUNT,
> +                "Wrong number of arguments to function '%s': expected 2 or 4, but got %u.", name, params->args_count);
> +        return false;
> +    }
> +
> +    if (params->args_count == 4)
> +    {
> +        hlsl_fixme(ctx, loc, "Samples with gradients are not implemented.\n");
> +    }
> +
> +
> Trivial nitpick: is this double empty line intended? Usually we don't use leave them.

-- 
https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/66#note_22446