16 May
2023
16 May
'23
5:48 p.m.
I won't ask for it for this patch, since I've already reviewed it, but in the future, please try to split up commits more. It's a lot easier to review with granular changes. E.g. in this case we could have had: * change "lod" to "params" * parse SamplerComparisonState * parse the SampleCmp() function * emit sm4 for HLSL_RESOURCE_SAMPLE_CMP -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/206#note_32910