Re: [PATCH 0/4] MR6733: Mfplat HTTP byte stream implementation

[Nikolay Sivov (＠nsivov)]

Nikolay Sivov (@nsivov) commented about dlls/mfplat/network.c:
> +        goto error;
> +    }
> +
> +    IMFAttributes_SetString(&object->attributes.IMFAttributes_iface, &MF_BYTESTREAM_EFFECTIVE_URL, object->url);
> +    IMFAttributes_SetString(&object->attributes.IMFAttributes_iface, &MF_BYTESTREAM_CONTENT_TYPE,
> +                            object->content_type ? object->content_type : L"application/octet-stream");
> +    if (object->last_modified != -1ULL)
> +    {
> +        ul.QuadPart = object->last_modified;
> +        ft.dwLowDateTime = ul.u.LowPart;
> +        ft.dwHighDateTime = ul.u.HighPart;
> +        IMFAttributes_SetBlob(&object->attributes.IMFAttributes_iface, &MF_BYTESTREAM_LAST_MODIFIED_TIME, (void *)&ft,
> +                              sizeof(ft));
> +    }
> +
> +    LeaveCriticalSection(&object->cs);
> Why are you locking during object creation?

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/6733#note_86075