14 Apr
2025
14 Apr
'25
5:06 p.m.
Matteo Bruni (@Mystral) commented about dlls/d3dx9_36/tests/surface.c:
const uint8_t *dst_expected_row = ((const uint8_t *)tests[i].expected_dst_data) + (sizeof(uint32_t) * 4 * y); const uint8_t *dst_row = ((const uint8_t *)lock_rect.pBits) + (lock_rect.Pitch * y);
- if (memcmp(dst_row, dst_expected_row, sizeof(uint32_t) * 4)) - mismatch_count++; + ok(!memcmp(dst_row, dst_expected_row, sizeof(uint32_t) * 4), "Unexpected line %u.\n", y);
Either way it's fine but I don't see a reason for introducing one way two patches earlier and changing it here. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7711#note_100804