2 Nov
2023
2 Nov
'23
11:33 p.m.
On Thu Nov 2 13:26:15 2023 +0000, Giovanni Mascellani wrote:
You can compute this inside `sm4_numeric_register_from_deref()`, since `deref` is available there too. I see no real reason for moving it here. I prefer it to be here, since in (possible) future patches, e.g. [efaa9b76b](https://gitlab.winehq.org/fcasas/vkd3d/-/commit/efaa9b76ba3d6ed71c07926c34a5...) and [559d4121](https://gitlab.winehq.org/fcasas/vkd3d/-/commit/559d412188ea57f196653183bfce...), sm4_numeric_register_from_deref() is called from other places in sm4_register_from_deref() and I don't want to introduce redundant checks.
-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/435#note_50738