Jinoh Kang (@iamahuman) commented about tools/wine/wine.rs:
+} + +fn is_pe_target(_target: &Target) -> bool { + // Implement platform-specific PE detection logic if needed + false +} + +fn load_ntdll(bindir_in: Option<String>, libdir_in: Option<String>) -> Library { + let arch_dir = get_arch_dir(&get_default_target()); + let winedllpath = env::var("WINEDLLPATH").unwrap_or_default(); + + unsafe { + if let Some(ref bindir) = bindir_in { + if bindir.ends_with("/tools/wine") { + let path = format!("{}/../../dlls/ntdll/ntdll.so", bindir); + if let Ok(lib) = Library::new(&path) { You could make `path` a temporary here. It's being unnecessary verbose.
-- https://gitlab.winehq.org/wine/wine/-/merge_requests/7717#note_99618