18 Jan
2023
18 Jan
'23
9:05 a.m.
On Wed Jan 18 07:53:36 2023 +0000, Huw Davies wrote:
I'd prefer to keep this patch simpler by just adding ```c err = ERROR_OUTOFMEMORY; ``` to the end of the for loop body. Okay. But I think that function has too many ways to deal with errors: 'goto err' in one case, 'break' in another, and 'return err' in yet another.
Also the fact that one can go through the 'err:' block both in case or error and in case of success is not really clean, particularly because the tables may or may not have been freed beforehand. But I guess that can go in a separate patch. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1978#note_21120