Re: [PATCH v4 0/2] MR979: d3d9: Implement d3dx_effect_SetRawValue

[Matteo Bruni (＠Mystral)]

Matteo Bruni (@Mystral) commented about dlls/d3dx9_36/effect.c:
> UINT byte_offset, UINT bytes)
>  {
> -    FIXME("iface %p, parameter %p, data %p, byte_offset %u, bytes %u stub!\n",
> +    struct d3dx_effect *src = impl_from_ID3DXEffect( iface );
> +    struct d3dx_parameter *param = get_valid_parameter( src, parameter );
> +    void *raw = NULL;
> +
> +    TRACE("iface %p, parameter %p, data %p, byte_offset %u, bytes %u.\n",
>              iface, parameter, data, byte_offset, bytes);
>
> -    return E_NOTIMPL;
> +    if (!src)
> +    {
> +        WARN("Invalid variable.\n");
> +        return E_FAIL;
> +    }

No point in checking that the This pointer is non-NULL.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/979#note_11083