28 May
2024
28 May
'24
8:52 p.m.
But I guess it's still a good idea to introduce tests in a separate commit? At least the removal of `wine_todo`s gives good indication what the commit is aiming for..
Yes, precisely. When it's feasible that helps a reviewer tell what the commit is trying to do. It also validates that it really is solving the problem it's supposed to, assuming the tests pass as they're supposed to. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5519#note_68774