6 Feb
2024
6 Feb
'24
3:20 a.m.
Kartavya Vashishtha (@kvashis) commented about dlls/kernelbase/file.c:
BOOL ret = FALSE; char *buffer;
+ DWORD flags = params ? params->dwCopyFlags : 0; + BOOL *cancel_ptr = params ? params->pfCancel : NULL; + PCOPYFILE2_PROGRESS_ROUTINE progress = params ? params->pProgressRoutine : NULL; + + if (cancel_ptr) + FIXME("pfCancel is not supported\n"); + if (progress) + FIXME("PCOPYFILE2_PROGRESS_ROUTINE is not supported\n");
Should these be moved below to the checks for unimplemented flags? (since they are also `FIXME`) I wrote these here so they're close to the variable declarations for `cancel_ptr` and `progress`. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5020#note_60146