Re: [PATCH v6 0/1] MR10174: bcryptprimitives: Make ProcessPrng always return `TRUE`

[Hans Leidekker (＠hans)]

Hans Leidekker (@hans) commented about dlls/bcryptprimitives/main.c:
> BOOL WINAPI ProcessPrng(BYTE *data, SIZE_T size)
>  {
> -    return RtlGenRandom(data, size);
> +    RtlGenRandom(data, size);
> +    /* ProcessPrng is documented as always returning TRUE */
> +    return TRUE;

I think an ERR() would still be good to have because RtlGenRandom() can fail according to the docs. It doesn't fail in the current implementation but an assert would be an additional guard against that changing and be more visible, but I don't mind leaving it out at this point. The question is whether it's better to abort the app or to continue without random data.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/10174#note_130474