16 Apr
2025
16 Apr
'25
9:33 p.m.
Alex Henrie (@alexhenrie) commented about dlls/ntdll/tests/pipe.c:
ok(res == STATUS_PENDING, "NtFsControlFile returned %lx\n", res);
res = pNtCancelIoFile(hPipe, &cancel_sb); + /* Save Status first thing after the call. We want to make very unlikely + * that the kernel APC updating Status could be executed after the call + * but before peeking at Status here. */ + status = iosb.Status;
If we want to be sure that `status` is saved immediately, should we make it volatile? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7797#note_101201