15 Dec
2022
15 Dec
'22
5:53 p.m.
Matteo Bruni (@Mystral) commented about dlls/d3dx9_36/tests/texture.c:
} } - - IDirect3DCubeTexture9_Release(tex); } - else - skip("Failed to create texture\n"); +} + +static void test_D3DXFillCubeTexture(IDirect3DDevice9 *device) +{ + IDirect3DCubeTexture9 *tex; + HRESULT hr; + + hr = IDirect3DDevice9_CreateCubeTexture(device, 4, 0, 0, D3DFMT_A8R8G8B8, D3DPOOL_MANAGED, &tex, NULL); + ok(hr == D3D_OK, "Failed to create a cube texture, hr %#lx.\n", hr);
Given that you're touching these ok() lines anyway, maybe replace them with the the generic ```suggestion:-0+0 ok(hr == D3D_OK, "Unexpected hr %#lx.\n", hr); ``` -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1682#note_19700