Zhiyi Zhang (@zhiyi) commented about dlls/comctl32/tests/propsheet.c:
}
+static void test_invalid_hpropsheetpage(void) +{ + BYTE buf_psp[sizeof(ULONG_PTR) + sizeof(PROPSHEETPAGEA)]; + BYTE buf_pspW[sizeof(ULONG_PTR) + sizeof(PROPSHEETPAGEW)]; + HPROPSHEETPAGE hpsp[1]; + PROPSHEETHEADERW pshW; + PROPSHEETHEADERA psh; + PROPSHEETPAGEA *psp; + PROPSHEETPAGEW *pspW; + LRESULT ret; + HWND hdlg; + + /* LocalSize throws exception on misaligned pointers (x86_64). */ + psp = (PROPSHEETPAGEA*)((ULONG_PTR)buf_psp & 0xf ? buf_psp : buf_psp + sizeof(ULONG_PTR)); Please add a space before *.
And could you add some comments documenting what invalid configuration are you testing? It's not obvious to me, to be honest. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/932#note_9502