6 Feb
2025
6 Feb
'25
1:26 p.m.
William Horvath (@whrvt) commented about include/winnt.h:
#if defined(__x86_64__) || defined(__i386__)
```suggestion:-0+0 #if !defined(__clang__) && (defined(__GNUC__) && (__GNUC__ < 8 || (__GNUC__ == 8 && __GNUC_MINOR__ < 1)) && (defined(__x86_64__) || defined(__i386__))) ``` since this was [fixed](https://gcc.gnu.org/git/?p=gcc.git&a=commit;h=d8c40eff56f69877b33c697ded756d...) quite a while ago? This would make the include guards that your patch adds elsewhere quite messy, but I think the intrinsics should be preferred if they're not broken. Is there another reason we avoid them completely, besides what's in the GCC bugzilla link? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7237#note_93895