Re: [PATCH 0/7] MR724: vkd3d-shader/hlsl: Improve SM1 support for non-float operations, part 4.

[Giovanni Mascellani (＠giomasce)]

Giovanni Mascellani (@giomasce) commented about libs/vkd3d-shader/hlsl.y:
> check_condition_type(ctx, condition);
>
> -    if (!(not = hlsl_new_unary_expr(ctx, HLSL_OP1_LOGIC_NOT, condition, &condition->loc)))
> +    bool_type = hlsl_get_numeric_type(ctx, condition->data_type->class, HLSL_TYPE_BOOL,
> +            condition->data_type->dimx, condition->data_type->dimy);

Notice that `check_condition_type()` already checks that this is a scalar-like. Maybe you can just cast to a scalar `bool`.

-- 
https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/724#note_64886