Re: [PATCH 0/19] MR1191: msvcm: add missing function implementation

[Piotr Caban (＠piotr)]

Piotr Caban (@piotr) commented about dlls/msvcp90/ios.c:
> basic_filebuf_wchar_dtor(&filebuf_wchar_log);
>  }
>
> -
>  // ?_Cin_func(a)std@@YAAAV?$basic_istream(a)DU?$char_traits(a)D@std@@@1(a)XZ
>  // ?_Cin_func(a)std@@YAAEAV?$basic_istream(a)DU?$char_traits(a)D@std@@@1(a)XZ
> +// class std::basic_istream<char,struct std::char_traits<char> > & __cdecl std::_Cin_func(void)

I'm not sure what to think about adding demangled function headers in comments. While it can improve readability in some cases it adds a lot of redundant information. Please stick to current style of not adding them - we can discuss adding them on wine-devel or in separate MR.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/1191#note_12496