Re: [PATCH v3 0/3] MR1199: xmllite/writer : Implement a few APIs

[Nikolay Sivov (＠nsivov)]

Nikolay Sivov (@nsivov) commented about dlls/xmllite/writer.c:
> return write_escaped_string(This, string, ~0u);
>  }
>
> +static HRESULT WINAPI xmlwriter_WriteChars(IXmlWriter *iface, const WCHAR *pwch, UINT cwch)
> +{
> +    xmlwriter *writer = impl_from_IXmlWriter(iface);
> +
> +    TRACE("%p, %s, %d\n", writer, debugstr_wn(pwch, cwch), cwch);
> +
> +    if ((pwch == NULL && cwch != 0))
> +        return WC_E_XMLCHARACTER;
> +    else if ((pwch == NULL && cwch == 0))
> +        return S_OK;
> +    else if ((is_empty_string(pwch) && cwch == 0))
> +        return S_OK;

It's not clear if this should come before state checks.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/1199#note_16524