26 Oct
2023
26 Oct
'23
11:50 a.m.
Nikolay Sivov (@nsivov) commented about dlls/mfmediaengine/main.c:
EnterCriticalSection(&engine->cs);
+ if (engine->flags & FLAGS_ENGINE_SHUT_DOWN) + { + LeaveCriticalSection(&engine->cs); + TRACE("Engine is shut down, stopping...\n"); + IUnknown_Release(object); + return S_OK; + }
Now this is calling Release() on a null 'object'. I don't know if we need a trace message here, but if we need it, something else, we are not stopping anything here, in playback or thread/process terms. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4133#note_49840