2 Aug
2023
2 Aug
'23
12:58 p.m.
I still have to work my way through the last patch, so I'm sending a couple of preliminary comments for the moment. Also, after the last commit four tests fail here (on RADV and llvmpipe) with this assertion: ``` shader_runner: ../vkd3d/libs/vkd3d/command.c:434: root_signature_get_descriptor_table: Assertion `p->parameter_type == D3D12_ROOT_PARAMETER_TYPE_DESCRIPTOR_TABLE' failed. ``` The tests are: * `compute.shader_test` * `numthreads.shader_test` * `uav-out-param.shader_test` * `uav-load.shader_test` -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/294#note_41055