Re: [PATCH 0/6] MR717: vkd3d-shader/fx: Add initial support for writing fx_2_0 parameters.

[Zebediah Figura (＠zfigura)]

Zebediah Figura (@zfigura) commented about libs/vkd3d-shader/fx.c:
> list_init(&fx->types);
>
> fx->child_effect = fx->ops->are_child_effects_supported && ctx->child_effect;
> +
> +    hlsl_block_init(&block);
> +    hlsl_prepend_global_uniform_copy(fx->ctx, &block);
> +    hlsl_block_init(&block);

I missed when this was done before, but this looks wrong (for one, it's generating instructions that get thrown away, and in fact leaked; for two, the block is subsequently initialized but never used). What's the intent here?

-- 
https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/717#note_64641