Nikolay Sivov (@nsivov) commented about dlls/mfmediaengine/tests/mfmediaengine.c:
hr = IMFMediaEngineEx_InsertVideoEffect(media_engine_ex, (IUnknown *)&video_effect2->IMFTransform_iface, FALSE); - todo_wine ok(hr == S_OK, "Unexpected hr %#lx.\n", hr); + ok(hr == S_OK, "Unexpected hr %#lx.\n", hr); EXPECT_REF(&video_effect2->IMFTransform_iface, 2);
hr = IMFMediaEngineEx_InsertVideoEffect(media_engine_ex, (IUnknown *)&video_effect3->IMFTransform_iface, FALSE); - todo_wine ok(hr == S_OK || broken(hr == MF_E_INVALIDREQUEST), "Unexpected hr %#lx.\n", hr); + ok(hr == S_OK || broken(hr == MF_E_INVALIDREQUEST), "Unexpected hr %#lx.\n", hr);
- if (FAILED(hr)) /* Win8 to Win10v1507 and Wine */ + if (FAILED(hr)) { + win_skip("Inserting more than two effects fails on Win8 to Win10v1507 %#lx, skipping tests.\n", hr); goto done; }
If it's a matter of 2 or 3 and not about more than 1, let's use 2, and remove this skip. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2778#note_36421