7 Nov
2025
7 Nov
'25
3:12 p.m.
Alexandre Julliard (@julliard) commented about server/fd.c:
+ if (get_reply_max_size() < sizeof(REPARSE_GUID_DATA_BUFFER)) + { + set_error( STATUS_BUFFER_TOO_SMALL ); + return; + } + + if ((ret = xattr_fget( fd->unix_fd, XATTR_REPARSE, NULL, 0 )) < 0) + { + file_set_error(); + return; + } + + if (!(buffer = mem_alloc( ret ))) return; + + if ((ret = xattr_fget( fd->unix_fd, XATTR_REPARSE, buffer, ret )) >= 0) + { It would be nice to avoid calling xattr_fget twice.
-- https://gitlab.winehq.org/wine/wine/-/merge_requests/9293#note_121171