12 Nov
2025
12 Nov
'25
8:16 p.m.
Esme Povirk (@madewokherd) commented about dlls/ole32/filelockbytes.c:
static HRESULT WINAPI FileLockBytesImpl_Flush(ILockBytes* iface) { + FileLockBytesImpl *This = impl_from_ILockBytes(iface); + + TRACE("(%p)\n", iface); + + /* verify a sane environment */ + if (!This) return E_FAIL; + + if (This->flProtect != PAGE_READWRITE) + return STG_E_ACCESSDENIED;
I think we should have a test for this. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9431#note_121712