28 Nov
2024
28 Nov
'24
10:56 a.m.
Jacek Caban (@jacek) commented about dlls/winevulkan/vulkan.c:
void wine_vkDestroyDevice(VkDevice client_device, const VkAllocationCallbacks *allocator) { - struct wine_device *device = wine_device_from_handle(client_device); + struct vulkan_device *device = vulkan_device_from_handle(client_device); + struct wine_device *impl = CONTAINING_RECORD(device, struct wine_device, obj);
Why do you remove `wine_device_from_handle`? All those `CONTAINING_RECORD`s don't seem like an improvement. We could have both `wine_*` helpers (private in winevulkan) and `vulkan_*` (in `vulkan_driver.h`). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6916#note_89101