Re: [PATCH 0/2] MR58: vkd3d-shader/hlsl: Reinterpret minimum precision types as their regular counterparts.

[Zebediah Figura (＠zfigura)]

Zebediah Figura (@zfigura) commented about libs/vkd3d-shader/hlsl.y:
> | TYPE_IDENTIFIER
>          {
>              $$ = hlsl_get_type(ctx->cur_scope, $1, true);
> +            if ($$->is_minimum_precision)
> +            {
> +                if (ctx->profile->major_version < 4)
> +                {
> +                    hlsl_error(ctx, &@1, VKD3D_SHADER_ERROR_HLSL_INVALID_TYPE,
> +                            "Target profile doesn't support minimum-precision types.");
> +                }
> +                else
> +                {
> +                    WARN("Reinterpreting type %s.\n", $$->name);

Personally I think this should be a FIXME, not a WARN.

-- 
https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/58#note_19816