On Mon Jul 15 22:33:24 2024 +0000, Francisco Casas wrote:
* Should I use copy_plane(), introduced in 2/2 also in the implementation of the other formats? Changing what needs to be changed to preserve behavior of course.
I would at least use it for the manual cases, but leaving the memcpy() fast path seems like a good idea. On second thought, that might not be a good idea, since for the manual cases sometimes the amount of data that needs to be copied (`width * depth / 8`) won't be the same as `src_pitch` (which is aligned to each word) and I am not sure adding an additional parameter to copy_plane() is worth it, same for inverting the image vertically. I limited myself to just fix the format then. That's not important, though. The extra data that's copied past the pitch is alignment padding and will eventually be discarded anyway.
-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6069#note_76297