Re: [PATCH v3 0/2] MR2496: Fix hang when a program calls IMFMediaSession_Start with an invalid source.

[Nikolay Sivov (＠nsivov)]

Nikolay Sivov (@nsivov) commented about dlls/mf/session.c:
> PropVariantCopy(&session->presentation.start_position, start_position);
>
> -            session_subscribe_sources(session);
> +            if (FAILED(hr = session_subscribe_sources(session))) {
> +                session_command_complete_with_event(session, MESessionStarted, hr, NULL);
> +                return;
> +            }
>
> LIST_FOR_EACH_ENTRY(source, &session->presentation.sources, struct media_source, entry)
>              {
>                  if (FAILED(hr = IMFMediaSource_Start(source->source, source->pd, &GUID_NULL, start_position)))
> +                {
>                      WARN("Failed to start media source %p, hr %#lx.\n", source->source, hr);
> +                    session_command_complete_with_event(session, MESessionStarted, hr, NULL);
> +                    return;
> +                }

This should be two separate changes.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/2496#note_29332