Re: [PATCH v3 0/2] MR5247: user32/msgbox: Support WM_COPY Message

[Zebediah Figura (＠zfigura)]

Zebediah Figura (@zfigura) commented about dlls/user32/msgbox.c:
> }
>  }
>
> +HHOOK msghook_handle;
> +
> +LRESULT CALLBACK msg_hook_proc(int nCode, WPARAM wParam, LPARAM lParam)
> +{
> +    MSG *msg = (MSG *)lParam;
> +    if (nCode == MSGF_DIALOGBOX && msg->message == WM_KEYUP)
> +    {
> +        if ( (msg->wParam == 'C' || msg->wParam == 'c') && (NtUserGetKeyState(VK_CONTROL) & 0x8000))

That doesn't work; there are multiple orderings of key presses and releases that should yield Ctrl-C, and this won't catch the case where the Ctrl key is released before C. You probably want WM_CHAR.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/5247#note_65001