Rémi Bernon (@rbernon) commented about dlls/winegstreamer/wg_transform.c:
#define GST_SAMPLE_FLAG_WG_CAPS_CHANGED (GST_MINI_OBJECT_FLAG_LAST << 0)
+/* This GstElement takes buffers from its sink pad, instead of pushing them + * out the src pad, it keeps them in a internal queue until the push function + * is called manually. + */ +typedef struct _GstHold +{ + GstElement element; + GstPad *src, *sink; + GstAtomicQueue *fifo; +} GstHold;
I don't think we should prefix our custom elements with Gst/gst_. Other custom objects use Wg/wg_ prefixes. Also I think "hold" is a verb and it would probably be more idiomatic to use a noun here like "holder" or "queue" as it's kind of the same purpose as the builtin queue but with custom semantics. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7288#note_95985