3 Apr
2023
3 Apr
'23
9:53 a.m.
On Mon Apr 3 08:33:03 2023 +0000, Rémi Bernon wrote:
Yeah it was just a suggestion, I didn't check it. You should use `$3 && type_get_type($3) != TYPE_RUNTIMECLASS` instead of two ifs. Yeah, I realized that after pushing and was going to add a comment. Though, I'm curious why there's no error checking in the helper functions. Wouldn't it be better to check if the parameter is NULL there?
-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2559#note_28648