Re: [PATCH v2 0/1] MR824: ntoskrnl: Implement KeGetCurrentProcessorNumberEx

[Etaash Mathamsetty (＠etaash.mathamsetty)]

On Mon Sep 12 01:56:43 2022 +0000, Zhiyi Zhang wrote:
> Space after if. ProcNumber -> process_number. And the parameter is
> optional so you need to check for NULL pointers. Also, I think the
> PROCESSOR_NUMBER structure is simple enough to be stubbed as well. Just
> report all Group and Reserved as zero and Number from
> NtGetCurrentProcessorNumber() and then print a FIXME. A FIXME at the
> start saying the function is a semi-stub is also helpful.
> that was my original patch, but I thought that would not be even close to correct lol  
> I'll fix this.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/824#note_8262