Re: [PATCH v4 0/2] MR4045: kernelbase: Rewrite ExpandEnvironmentStringsA to return ansi string size

[Nikolay Sivov (＠nsivov)]

Nikolay Sivov (@nsivov) commented about dlls/kernel32/tests/environ.c:
> +static void test_ExpandEnvironmentStringsW(void)
> +{
> +    const WCHAR *value = L"Long long value";
> +    WCHAR buf[256];
> +
> +    SetLastError(0xdeadbeef);
> +    wcscpy(buf, L"abcdef");
> +    ExpandEnvironmentStringsW(value, buf, 0);
> +    ok(GetLastError() == 0xdeadbeef, "got last error %ld\n", GetLastError());
> +    ok(!wcscmp(buf, L"abcdef"), "got %s\n", debugstr_w(buf));
> +
> +    SetLastError(0xdeadbeef);
> +    wcscpy(buf, L"abcdef");
> +    ExpandEnvironmentStringsW(value, buf, 1);
> +    ok(GetLastError() == 0xdeadbeef, "got last error %ld\n", GetLastError());
> +    ok(!wcscmp(buf, L"abcdef"), "got %s\n", debugstr_w(buf));
> This does not test return values, or cases when expansion actually happens.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/4045#note_53764