12 Nov
2025
12 Nov
'25
3:19 p.m.
Jacek Caban (@jacek) commented about dlls/mshtml/omnavigator.c:
static HRESULT WINAPI crypto_getRandomValues(IWineMSHTMLCrypto *iface, VARIANT *typedArray, IDispatch **ret) { struct crypto *crypto = impl_from_IWineMSHTMLCrypto(iface); + IWineJSDispatch *jsdisp; + HRESULT hres;
- FIXME("(%p)->(%p %p)\n", crypto, typedArray, ret); + TRACE("(%p)->(%p %p)\n", crypto, typedArray, ret);
- return E_NOTIMPL; + if(V_VT(typedArray) != VT_DISPATCH || !V_DISPATCH(typedArray)) + return E_INVALIDARG; Could `typedArray` be `IDispatch *` in IDL file instead of `VARIANT`?
-- https://gitlab.winehq.org/wine/wine/-/merge_requests/9426#note_121678