Re: [PATCH v6 0/5] MR211: vkd3d-shader/hlsl: Support clip() intrinsic.

[Giovanni Mascellani (＠giomasce)]

Giovanni Mascellani (@giomasce) commented about libs/vkd3d-shader/hlsl.c:
> return dst;
>  }
>
> -static struct hlsl_ir_node *clone_jump(struct hlsl_ctx *ctx, struct hlsl_ir_jump *src)
> +static struct hlsl_ir_node *clone_jump(struct hlsl_ctx *ctx, struct clone_instr_map *map, struct hlsl_ir_jump *src)
>  {
> -    return hlsl_new_jump(ctx, src->type, &src->node.loc);
> +    struct hlsl_ir_node *node;
> +    struct hlsl_ir_jump *jump;
> +
> +    if (!(node = hlsl_new_jump(ctx, src->type, NULL, &src->node.loc)))
> +        return NULL;
> +    jump = hlsl_ir_jump(node);
> +    clone_src(map, &jump->condition, &src->condition);

Maybe `hlsl_new_jump(map_instr(&src->condition.nome))` is simpler?

-- 
https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/211#note_35121