Alexandros Frantzis (@afrantzis) commented about dlls/winewayland.drv/window.c:
} }
+/***************************************************************** + * WAYLAND_SetWindowText + */ +void WAYLAND_SetWindowText(HWND hwnd, LPCWSTR text) +{ + struct wayland_surface *wsurface = wayland_surface_lock_hwnd(hwnd); + + TRACE("hwnd=%p text=%s\n", hwnd, wine_dbgstr_w(text)); + + if (wsurface && wsurface->xdg_toplevel)
We need to protect against NULL wayland_surface \* (the experimental code handled this differently). Also please use `surface` instead of `wsurface` as the variable name (for consistency with how we ended up naming such variables in the upstream version). ```suggestion:-0+3 if (surface) { if (surface->xdg_surface) wayland_surface_set_title(surface, text); pthread_mutex_unlock(&surface->mutex); } ``` -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5178#note_63082