26 Jul
2023
26 Jul
'23
8:20 a.m.
On Wed Jul 26 07:51:09 2023 +0000, Zhao Yi wrote:
After my efforts I found it a bit difficult to rewrite this test in a way that doesn't depend on Wine internals. As I said in MR2394, I can approve the commit after you change the commit message. The change is simple enough that I think it's fine without a test. It could be difficult to test this specific variable. So you can remove the tests for this MR. I didn't approve MR2394 because you chose to close the MR later. By the way, you don't need to close and open a new MR for updated versions of commits.
-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3392#note_40261