1 Mar
2025
1 Mar
'25
10:13 p.m.
Esme Povirk (@madewokherd) commented about dlls/windowscodecs/metadataquery.c:
+ IWICEnumMetadataItem *metadata_enumerator = NULL; + IEnumUnknown *object_enumerator = NULL; struct string_enumerator *object;
if (!(object = calloc(1, sizeof(*object)))) return E_OUTOFMEMORY;
- object->IEnumString_iface.lpVtbl = &string_enumerator_vtbl; - object->ref = 1; + if (is_block_handler(handler)) + { + IWICMetadataBlockReader_GetEnumerator(handler->object.block_reader, &object_enumerator); + } + else + { + IWICMetadataReader_GetEnumerator(handler->object.reader, &metadata_enumerator); `metadata_enumerator` needs to be released.
-- https://gitlab.winehq.org/wine/wine/-/merge_requests/7407#note_96334