Re: [PATCH 0/2] MR4479: winegstreamer: Implement wg_muxer_finalize.

[Rémi Bernon]

Rémi Bernon (@rbernon) commented about dlls/winegstreamer/media_sink.c:
> +    if (FAILED(hr = async_command_create(ASYNC_FINALIZE, &command)))
> +    {
> +        LeaveCriticalSection(&media_sink->cs);
> +        return hr;
> +    }
> +
> +    if (callback)
> +    {
> +        if (FAILED(hr = MFCreateAsyncResult(NULL, callback, state, &result)))
> +        {
> +            LeaveCriticalSection(&media_sink->cs);
> +            free(command);
> +            return hr;
> +        }
> +        IMFAsyncResult_AddRef((command->u.finalize.result = result));
> +    }
> Can `callback` really be NULL? In that case you're later calling `MFInvokeCallback` with a NULL `result`.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/4479#note_53485