Re: [PATCH 0/4] MR1122: comctl32: property sheet improvements

[Zhiyi Zhang (＠zhiyi)]

Zhiyi Zhang (@zhiyi) commented about dlls/comctl32/propsheet.c:
> static DWORD HPSP_get_flags(HPROPSHEETPAGE hpsp)
>  {
>      if (!hpsp) return 0;
> -    return hpsp->psp.dwFlags;
> +    return hpsp->unicode ? hpsp->pspW.dwFlags : hpsp->pspA.dwFlags;
>  }
>
> static void HPSP_call_callback(HPROPSHEETPAGE hpsp, UINT msg)
>  {
> -    if (!(hpsp->psp.dwFlags & PSP_USECALLBACK) || !hpsp->psp.pfnCallback ||
> -            (msg == PSPCB_ADDREF && hpsp->psp.dwSize <= PROPSHEETPAGEA_V1_SIZE))
> -        return;
> +    if (hpsp->unicode)
> +    {
> +        if (!(hpsp->pspW.dwFlags & PSP_USECALLBACK) || !hpsp->pspW.pfnCallback ||
> +                (msg == PSPCB_ADDREF && hpsp->pspW.dwSize <= PROPSHEETPAGEA_V1_SIZE))
> PROPSHEETPAGEA_V1_SIZE is used instead of PROPSHEETPAGEW_V1_SIZE. Is it correct?

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/1122#note_11896