Re: [PATCH 0/3] MR1542: winegstreamer: Get MF_SD_LANGUAGE and (for QT demuxer only) MF_SD_STREAM_NAME.

[Zebediah Figura (＠zfigura)]

Zebediah Figura (@zfigura) commented about dlls/winegstreamer/media_source.c:
> +        }
> +        tags[] =
> +        {
> +            {WG_PARSER_TAG_LANGUAGE, &MF_SD_LANGUAGE},
> +        };
> +        unsigned int j;
> +        char str[128];
> +        WCHAR *strW;
> +        DWORD len;
> +
>          IMFMediaStream_GetStreamDescriptor(&object->streams[i]->IMFMediaStream_iface, &descriptors[i]);
> +
> +        for (j = 0; j < ARRAY_SIZE(tags); ++j)
> +        {
> +            if (!wg_parser_stream_get_tag(object->streams[i]->wg_stream, tags[j].tag, str, sizeof(str)))
> +                continue;
> We should try to reallocate a dynamic buffer, instead of failing if the fixed buffer is too short. [There are, of course, many ways to do this; I don't have strong opinions on which is the best.]

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/1542#note_17588