16 Feb
2024
16 Feb
'24
6:26 p.m.
Rémi Bernon (@rbernon) commented about dlls/dmime/midi.c:
+ HRESULT hr = S_OK; + + *out = 0; + do + { + hr = stream_read_at_most(stream, &byte, 1, bytes_left); + if (hr != S_OK) return hr; + *out = (*out << 7) | (byte & 0x7f); + } while (byte & 0x80); + return S_OK; +} + +static HRESULT read_midi_event(IStream *stream, BYTE *last_status, ULONG *bytes_left) +{ + BYTE byte; + BYTE status, meta_event_type; Nit: Fwiw Wine usually prefers grouping variable declarations of the same type.
```suggestion:-1+0 BYTE byte, status, meta_event_type; ``` -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5081#note_61503