Nikolay Sivov (@nsivov) commented about dlls/msxml3/element.c:
+ + TRACE("(%p)->(%p %p)\n", This, domAttribute, attributeNode); + + if (!domAttribute) { + return E_INVALIDARG; + } + attr_node = get_node_obj((IXMLDOMNode*)domAttribute); + if (This->node.node != attr_node->node->parent) { + return E_INVALIDARG; + } + + if (attributeNode) { + xmlUnlinkNode(attr_node->node ); + xmldoc_add_orphan(attr_node->node->doc, attr_node->node); + *attributeNode = (IXMLDOMAttribute*)create_node(attr_node->node); + } I don't think we have a test for null out argument, for when attribute still exists.
Please make some cosmetic changes, so we don't have to reiterate just on that: - for single line blocks, there is no need for braces; - when there are braces, let's have opening one on a new line. As mentioned by previous comment, please squash your changes into a single commit, then do "git push --force" to the same branch to overwrite. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9056#note_117413