Re: [PATCH v2 0/1] MR113: vkd3d-shader/dxbc: Validate and skip the signature section header size.

[Zebediah Figura (＠zfigura)]

Zebediah Figura (@zfigura) commented about libs/vkd3d-shader/dxbc.c:
> read_dword(&ptr, &count);
>      TRACE("%u elements.\n", count);
>
> -    skip_dword_unknown(&ptr, 1); /* It seems to always be 0x00000008. */
> +    read_dword(&ptr, &header_size);
> +    if (header_size & (sizeof(uint32_t) - 1))
> +    {
> +        WARN("Header size %#x is not 32-bit aligned.\n", header_size);
> +        return VKD3D_ERROR_INVALID_ARGUMENT;
> +    }
> +    header_size /= sizeof(uint32_t);
> +    if (header_size < 2)
> +    {
> +        WARN("Invalid header size %u.\n", header_size);
> +    }

Should we return an error here?

-- 
https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/113#note_26149