Re: [PATCH 0/1] MR1024: xmllite/writer: Correctly partially duplicate strings

[Nikolay Sivov (＠nsivov)]

Nikolay Sivov (@nsivov) commented about dlls/xmllite/writer.c:
> if (len == -1)
>          len = lstrlenW(str);
>
> -    size = (len + 1) * sizeof(WCHAR);
> -    ret = writer_alloc(writer, size);
> -    if (ret) memcpy(ret, str, size);
> +    ret = writer_alloc(writer, (len + 1 ) * sizeof(WCHAR));

Please remove extra space there. Otherwise looks good. Does the issue appear with wcscmp() for such strings, or how did you spot this?

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/1024#note_10400