Re: [PATCH 0/1] MR5407: winegstreamer: Set GST_DEBUG if not set, based on WINEDEBUG channels.

[Elizabeth Figura (＠zfigura)]

Elizabeth Figura (@zfigura) commented about dlls/winegstreamer/unixlib.c:
> char **argv = args;
>      GError *err;
>
> +    if (params->trace_on)
> +        setenv("GST_DEBUG", "WINE:9,4", FALSE);
> +    if (params->warn_on)
> +        setenv("GST_DEBUG", "3", FALSE);
> +    if (params->err_on)
> +        setenv("GST_DEBUG", "1", FALSE);
> +    setenv("GST_DEBUG_NO_COLOR", "1", FALSE);

We shouldn't override variables set by the user.

Also I'm pretty sure that e.g. TRACE_ON implies ERR_ON, so this will always result in GST_DEBUG=1.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/5407#note_66145