1 Dec
2023
1 Dec
'23
8:19 a.m.
On Thu Nov 30 22:00:44 2023 +0000, Zebediah Figura wrote:
"if (x) ok(0)" should almost always be "ok(!x)". It does more than just ok(0). I did it like this to ensure that everything is in order except exactly one unexpected rewind.
Would you prefer if I just tell the tests to explicitly rewind the stream when changing compression mode? [As mentioned in wm_reader.c](https://gitlab.winehq.org/wine/wine/-/blob/master/dlls/winegstreamer/wm_read...), no plausible program reconfigures streams dynamically anyways. Always hard to know which tests are important, and which are safe to relax... -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4449#note_54578