22 May
2023
22 May
'23
1:33 p.m.
Giovanni Mascellani (@giomasce) commented about libs/vkd3d-shader/tpf.c:
{ var = extern_resources[i];
- string_offset = put_string(&buffer, var->name); + if (!strncmp(var->name, "<resource>", strlen("<resource>"))) + string_offset = put_string(&buffer, var->name + strlen("<resource>")); + else + string_offset = put_string(&buffer, var->name);
I'm not sure I like this (specifically, emitting a variable name that it mangled or not depending on the name itself). I guess you're doing it to mimic native? -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/209#note_33392